search

ansforge / psc-rass-loader

module de chargement des modifications quotidiennes du RASS dans la base de données Sec-PSC
1 stars 0 forks source link

Harcoded configuration remains in the diff code and bypasses configuration #25

Closed edegenetais-nx closed 7 months ago

edegenetais-nx commented 7 months ago

The list of professions protected from identity deletion is hardcoded at the diff stage.

ReadyToComputeDiff.java : 121
                List<Ps> adeliFiltered = psPage.stream()
                        .filter(ps -> ps.getDeactivated() == null || ps.getDeactivated() < ps.getActivated())
                        .filter(ps -> !(ps.getIdType().equals(ID_TYPE.ADELI.value)
                                && ps.getProfessions().stream().anyMatch(profession -> profession.getCode().equals("60")))
edegenetais-nx commented 7 months ago

Problem NOT solved.

edegenetais-nx commented 7 months ago

The second test set was conclusive, bug solved.