feat: bookmarklet

[X140Yu]

demonstrate how to generate bookmarklet code based on latest code

Usage

• yarn run build:bookmarklet
• grab output in output/Bookmarklet.js and add its content as a bookmark

You can also toggle on/off of the reading mode.

[Explosion-Scratch]

Did you test this to check for chrome API's being undefined without the extension context?

[X140Yu]

Did you test this to check for chrome API's being undefined without the extension context?

It's ok to ignore these errors, we can use default configs.

[Explosion-Scratch]

Did you test this to check for chrome API's being undefined without the extension context?

It's ok to ignore these errors, we can use default configs.

Not if the errors prevent the code from running. Could you run the boomarklet build script and show it here? Also what do you think of using a GitHub action to do this as well?

[asieduernest12]

@X140Yu @Explosion-Scratch I think the shortcut is favourable over the bookmarklet. Lets close this?

[Explosion-Scratch]

@X140Yu @Explosion-Scratch I think the shortcut is favourable over the bookmarklet. Lets close this?

No thanks, I'm happy to use your version of the bookmarklet but I still think that the bookmarklet is important to have. It's just pure JS that can be run anywhere easily, and it allows for not installing the extension

[asieduernest12]

Interesting point. It's sure is cool to be able to get the toggle feature with out a full installation

[ansh]

@asieduernest12 @Explosion-Scratch @X140Yu

I have put instructions on installing the bookmarklet with both methods in the README (in this PR). I have clearly stated that this is not the recommended method as it will probably break on a lot more sites than our Browser Extension. I hope it is useful to people who know what a Bookmarklet is and use them often. I also think it is the best approach for our case since it ads instructions based on both this PR and PR #102.

If this sounds good to you all, feel free to merge the branch.

[asieduernest12]

yup totally feels good and a great approach.

[asieduernest12]

presently this is broken for me and i get this error

the build code is not bundling this it seems

[X140Yu]

The repo has changed a lot, and makes it more difficult to generate a separate bookmarklet script based on the latest code, I do agree that bookmarklet is not the way we want users to use this plugin, it's more buggy and hard to upgrade

[ansh]

hmm seems like a Webpack error

On Mon, Jun 6 2022 at 15:06, ERNEST ASARE-ASIEDU < @.*** > wrote:

presently this is broken for me and i get this error Screenshot from 2022-06-06 10-04-34 ( https://user-images.githubusercontent.com/20851930/172176814-a266956a-f846-40f6-b53a-e500db966769.png )

— Reply to this email directly, view it on GitHub ( https://github.com/ansh/jiffyreader.com/pull/113#issuecomment-1147485985 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AB6T25LJ4NKDQTBGQTJT6HDVNYAVTANCNFSM5XTR7TCQ ). You are receiving this because you commented. Message ID: <ansh/jiffyreader . com/pull/113/c1147485985 @ github. com>

[asieduernest12]

hmm seems like a Webpack error … On Mon, Jun 6 2022 at 15:06, ERNEST ASARE-ASIEDU < @.*** > wrote: presently this is broken for me and i get this error Screenshot from 2022-06-06 10-04-34 ( https://user-images.githubusercontent.com/20851930/172176814-a266956a-f846-40f6-b53a-e500db966769.png ) — Reply to this email directly, view it on GitHub ( #113 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AB6T25LJ4NKDQTBGQTJT6HDVNYAVTANCNFSM5XTR7TCQ ). You are receiving this because you commented. Message ID: <ansh/jiffyreader . com/pull/113/c1147485985 @ github. com>

@ansh this issue is already resolved and anyone can grab a bookmarklet from the releases page for any version https://github.com/ansh/jiffyreader.com/releases/download/1.0.9.1010/jiffyReader-bookmarklet.html