search

ansh / jiffyreader.com

A Browser Extension for faster reading on ANY website!
https://www.jiffyreader.com/
GNU General Public License v3.0
3.77k stars 201 forks source link

[BUG] Youtube seems to be caching wrong #114

Closed MissPotato closed 2 years ago

MissPotato commented 2 years ago

Describe the bug Various parts of youtube text begins to break with this plugin enabled.

Video titles get swapped around on both the homepage and the suggestions. Usernames get mashed up. Titles can be merged together.

To Reproduce Steps to reproduce the behavior:

  1. Go to youtube's homepage
  2. Turn plugin on
  3. Click any video
  4. Click the youtube button in the top left to go back to webpage
  5. Repeat from step 3 to progressively make things worse

Expected behavior Titles to match their video

Screenshots (Youtube before enabling)[https://i.imgur.com/jh7gzbk.jpeg] (After clicking a video and going back to homepage)[https://i.imgur.com/VQErRX4.jpeg] (Youtube video with messed up views and like count, Thanksclip button, subscribesubscribe button, video tags, suggestion thumbnails, suggestion usernames are merged, suggestions have wrong titles, live stream showing view count and not current watching)[https://i.imgur.com/iYadudC.png]

Desktop (please complete the following information):

Additional context Refreshing fixes it temporarily. All other plugins have been disabled.

asieduernest12 commented 2 years ago

thank you @MissPotato, looking into it

asieduernest12 commented 2 years ago

@MissPotato @ansh @X140Yu @meetbryce @jhonalino this bug is really challenging. youtubes an spa and looks like the video title and likes and dislikes are the most obvious evidence of the problem. we can take a look more into this over the coming days and hopefully get a good solution.

MissPotato commented 2 years ago

I'm willing to test experimental builds, though I don't have the means to compile from source, if you think that could help any! Thanks for looking into it!

asieduernest12 commented 2 years ago

I'm willing to test experimental builds, though I don't have the means to compile from source, if you think that could help any! Thanks for looking into it!

We dont really have experimental builds yet but you can get release 0.0.6 chrome.zip here

MissPotato commented 2 years ago

This definitely seemed to improved things drastically, however the issue still persists. https://i.imgur.com/0pEwJ1x.png This happened even with reader-mode off.

paxelpixel commented 2 years ago

thank you so much for testing @MissPotato!

@asieduernest12 looks like the logic to keep the text node alive is also off once you turn off the reader. but I never restored it to the original state. as the original parser leaves the br span behind. I'll work on a patch for this.

@MissPotato can you please confirm if this only happens once you turn off the reader? if not. which particular part of youtube are still affected?

MissPotato commented 2 years ago

At the time of this happening I had not yet enabled the reader mode. I've been jumping youtube videos to try and reproduce it and can not. It seems like the username of the uploader in the video was merged with a viewcount and upload time of a random youtube video. It was then duplicated annyplace their username showed up.

asieduernest12 commented 2 years ago

This definitely seemed to improved things drastically, however the issue still persists. https://i.imgur.com/0pEwJ1x.png This happened even with reader-mode off.

@MissPotato is the issue solved I tried looking at this and i feel my eyes are playing with me cos i dont see the issue. Let me know if it is solved or point out where i should be looking 😊 thanks

MissPotato commented 2 years ago

Oh, I see what's going on now. The youtuber's name actually IS "Henry Stickmin ∙ 2.3M views ∙ 10 hours 　 ago 2 weeks ago". It looked like the bug I was experiencing earlier. That would explain why I was unable to reproduce it, sorry about that! Yeah, this bug is fixed then, sorry again!