ansh / jiffyreader.com

A Browser Extension for faster reading on ANY website!
https://www.jiffyreader.com/
GNU General Public License v3.0
3.72k stars 200 forks source link

Issue #206: Translation file field name typo ("Hieght" -> "Height") #208

Closed gypsicoder closed 1 year ago

gypsicoder commented 1 year ago

This is my first contribution in the repo. It's very small part. Please let me know is the commit okay or not.

Thank you for giving time on reviewing the PR.

asieduernest12 commented 1 year ago

Commit it fine, normally keep the conversation messages relevant to the changes or a little humor for the algorithm lords. Would have been nice to include a note that said you already updated the ui files to pickup the updated fields. So anyone checking is freed from doing the mental calculations to land a space x rocket of which files they have to check although we are still going to just use the commit tab to look through the changes.

Nice commit. MoonsdaoRocketGIF

Fixes issue #206

gypsicoder commented 1 year ago

@asieduernest12 Thank you for the feedback.