ansh / jiffyreader.com

A Browser Extension for faster reading on ANY website!
https://www.jiffyreader.com/
GNU General Public License v3.0
3.72k stars 198 forks source link

[BUG] facebook edtiable content glitching #250

Closed Hikarea closed 1 year ago

Hikarea commented 1 year ago

Describe the bug I can't write comments on Facebook website, using Edge browser

To Reproduce Steps to reproduce the behavior on extension or a specific website: Just try to comment on a post on Facebook.com

Reproduce on the extension

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Reproduce on a website

  1. Visit this link: '...'
    • [x] check or mark with an x to indicate that the link is publicly accessible and also requires no account to be created.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

asieduernest12 commented 1 year ago

@Hikarea thank for reporting this issue. I will implement a fix for this that should be available in the next few days.

Casue: comments on facebook are implemented using non standard html resources Fix: add an exception for the comment element using [role=textarea] and [contenteditable=true] image AltFix: use an ml model to scan the dom and flag editable elements to be excluded from jiffyreader parsing Issues: user privacy obviously, the model would have to be local if implemented

generrosity commented 1 year ago

Hi @asieduernest12 ! just wondering if this was in place?

I see in your screenshot "role=textbox" but in your notes "role=textarea"

Im looking at Yammer/MS Viva Engage which uses the same css classes and would benefit from this :)

asieduernest12 commented 1 year ago

Hi @asieduernest12 ! just wondering if this was in place?

I see in your screenshot "role=textbox" but in your notes "role=textarea"

Im looking at Yammer/MS Viva Engage which uses the same css classes and would benefit from this :)

Hi @generrosity this is now resolved in the latest build 1.0.10.300 which should be available in the next few days in all extension stores (chrome, opera, firefox).

Unfortunately i am not familiar with Yammer/Ms what is though?

asieduernest12 commented 1 year ago

Yammer/Ms

@generrosity found out what yammer is, so the new update should also work for yammer and any website that has regular input fields and also custom input fields aslong as their are anotated with the contenteditable attribute PeaceOutDeucesGIF

generrosity commented 11 months ago

Many thanks! It took a while for it to flow through to Chrome, but its working great 👍👍👌

asieduernest12 commented 11 months ago

awesome feel free to give the project a ratting on chrome store. Helps the prject immensely.