ansh / jiffyreader.com

A Browser Extension for faster reading on ANY website!
https://www.jiffyreader.com/
GNU General Public License v3.0
3.72k stars 198 forks source link

[BUG] Breaks latex parsing when auto on enabled #259

Closed Bpklgs closed 1 year ago

Bpklgs commented 1 year ago

Kind of hard to describe but bolding pages before they load breaks parts of them

Reproduce on the extension

  1. Enable auto turn on
  2. Go to https://courseware.cemc.uwaterloo.ca/42/assignments/1139/1
  3. Scroll down a bit and you should see text that shouldn't be there image

Expected behavior go to the website and turn on the extension manually

Desktop (please complete the following information):

asieduernest12 commented 1 year ago

@Bpklgs please include a screen shot if you can to help with the investigation into the issue

asieduernest12 commented 1 year ago

@asieduernest12 currently you cannot use auto turn-on with this page

the issue: from the initial review, the page https://courseware.cemc.uwaterloo.ca/42/assignments/1139/1 is running some script to parse latex code and display them as math formula notations in human readable format

the auto turn on code runs immediately after the a page is ready this is causing the latex code to be jiffied and no longer be valid latex this means the latex parser is not seeing any valid latex code to transform

a intermetiate fix for this issue is to disable auto turn on for this site and then turn on jiffy manually after the page and latex is ready

an ideal programatic solution is to realease an update that will let you specify a trigger such checking for the presence or absence of some element which then allows auto turn on to engage

this maybe coupled with exponential backoff and retry limit to account for slow or degraded network conditions in order to provide a user experience that is acceptable with out introducing adverse penalties on user interactions

TLDR: disable auto turn on for https://courseware.cemc.uwaterloo.ca/42/assignments/1139/1 by using checking the customize for only this site and then disable auto turn on

asieduernest12 commented 1 year ago

features to consider