Closed anshuman23 closed 6 years ago
I love the return types. Great job!
Note though that you are returning a charlist (single-quoted) in the error message while a string/binary (double-quoted) would be preferred:
iex(2)> graph2 = Tensorflex.read_graph("Makefile")
{:error, "Unable to import graph"}
@josevalim as discussed in #3 , merged all graph reading capabilities into the
read_graph
function. This function returns aTF_Graph
on successful loading of graph and an{:error,"Unable to load graph"}
tuple on an unsuccessful attempt.Example is as follows (
classify_image_graph_def.pb
is from Google's Imagenet model):I have an idea for the "story" around the graph loading we had talked about, so I'll be merging this PR as already discussed and adding the details of that in the next PR for your review.