Refactoring the code for readability and some good practices

anshumanbh / tko-subs

A tool that can help detect and takeover subdomains with dead DNS records

MIT License

741 stars 137 forks source link

Refactoring the code for readability and some good practices #12

Closed high-stakes closed 6 years ago

high-stakes commented 6 years ago

Add some convenience features like thread limiting and well formatted output

removed global variables
removed inline comments -> moved relevant code to new functions
added proper error propagation / handling
added configuration struct to store user settings
added the ability to limit parallel threads when processing a file
new dependency: asciitables -> well formatted result table on the console
write to console when we have problems identifying service providers
add some extra providers

anshumanbh commented 6 years ago

wow, this was unexpected. Thanks a lot @high-stakes. I will take a look and merge, if everything looks right!

high-stakes commented 6 years ago

@anshumanbh great. One thing I did not test (or change) is the automatic takeover part.

anshumanbh commented 6 years ago

Everything else looks pretty solid. Once you are done with all the changes above, we can merge it. Thanks again for taking time and making this better! I really appreciate it..

Also, how can I contact you? I have something else that I am working on right now and I am looking for some collaboration. You will definitely find that interesting, if you like GOLANG and are into bug bounties. Let me know.

high-stakes commented 6 years ago

@anshumanbh Sure, I'm interested. We could use gitter for communication or what do you prefer?

anshumanbh commented 6 years ago

can you email me? anshuman.bhartiya@gmail.com. I will add you to my personal Slack where I collaborate with a few others as well..