search

anshumanv / chia-anime-downloader

Anime batch downloader script for https://chia-anime.tv
MIT License
20 stars 5 forks source link

Allow download through wget #12

Closed zuik closed 7 years ago

zuik commented 7 years ago

Follow up to #8

anshumanv commented 7 years ago

Thanks for this @zuik , however I'm facing this error. Can you please look into this, I'm running python 3.6.2 chia2 Download in #4 was working well but the PR was unfortunately closed, look into it if you need any references.

anshumanv commented 7 years ago

Btw congrats on crossing 1k gh contributions. 🎉

Yureien commented 7 years ago

Hey, in my opinion, we should use requests to download. This will lessen the amount of libs required to use this.

zuik commented 7 years ago

@FadedCoder I agree. We could leave this as an option but should default to requests. @anshumanv I think the problem is that Window doesn't have wget binary so that you get a file not exist error. And also thank you :)

anshumanv commented 7 years ago

@zuik any ideas on how to make it work on windows ?

zuik commented 7 years ago

We could bundle wget binary with it. But that has its own challenges. I gonna look into doing it through requests

anshumanv commented 7 years ago

Alright thanks, refer #4 if needed, it was working like a charm

Yureien commented 7 years ago

@zuik Please change it into requests. It will cause errors otherwise on systems where wget is not installed. Refer this if you need help - https://stackoverflow.com/a/16696317/5210825.

Yureien commented 7 years ago

Closing this as PR #16 resolves this.