search

anshumanv / chia-anime-downloader

Anime batch downloader script for https://chia-anime.tv
MIT License
20 stars 5 forks source link

Clean the script to make it more readable #2

Closed anshumanv closed 7 years ago

anshumanv commented 7 years ago

The current script is messed up, we can split them to individual functions and add docstrings as well.

NikolaJankovic commented 7 years ago

Working on this now!

anshumanv commented 7 years ago

Thanks !

Yureien commented 7 years ago

A request, please make this 4 spaces tab. The 8 spaces tab messes up my system.

anshumanv commented 7 years ago

Is it 8 ? Damn, 8 is too much 😞

Yureien commented 7 years ago

Yeah. It is showing 8 on my system. By the way do use Windows/Mac? The tabs are really messed up in my system.

NikolaJankovic commented 7 years ago

Will do

anshumanv commented 7 years ago

I use linux majorly and sometimes windows, but this project i did on windows i think @FadedCoder, code current;y looks ugly and has messed up indentation/spacing/newlines, hence opened this.

NikolaJankovic commented 7 years ago

There are also a number issues with the code when it's run on different platforms, for example the parser that bs4 uses for lxml has issues when run on osx (and maybe linux). I'm resolving all of this now, I'll have a pull request soon.

anshumanv commented 7 years ago

Thanks so much for you hard work @NikolaJankovic 👍

Yureien commented 7 years ago

I guess this issue should be closed, @anshumanv?

anshumanv commented 7 years ago

Thanks for the reminder @FadedCoder