Improve search by ID performace

anshumanv / evolutions-webapp

What? monferno is evolving!

https://evolutions.js.org

MIT License

17 stars 17 forks source link

Open anshumanv opened 6 years ago

anshumanv commented 6 years ago

We are iterating over each object to match it's num, this is poor in terms if performance, please improve it.

[x] I ensure that this issue is not a duplicate of any current open issues(s).
[ ] Assign this issue to me (I want to work on this).
[ ] I will send my PR only after I'm assigned to this issue by any maintainer.
[ ] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

sneakycrowllc commented 6 years ago

What is a different way it could be done?

Monal5031 commented 6 years ago

Well we can map the values to object and then do a BST over the numbers and retrieve back the chain we need.

dericcain commented 5 years ago

I gave this a shot in #46. This was a really good case for using a lookup table.