search

anshumanv / evolutions-webapp

What? monferno is evolving!
https://evolutions.js.org
MIT License
17 stars 17 forks source link

Added information box when hovering over pokemon #51

Closed jmeline closed 5 years ago

jmeline commented 5 years ago
Closes #28 #### By submitting this pull request I confirm I've read and complied with the below declarations. - [x] I have tested the changes locally and they are functional. - [x] I ensure that my commit message is in imperative manner. - [x] I ensure that I have properly referenced the related issue. - [x] I ensure that I sent this pull request after being assigned to the corresponding issue. - [x] This pull request has a descriptive title. For example, `Add/Fix {Feature/Bug}`, not `Update README.md` or `Add new code`. - [x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days. ![2018-10-02-225505_3520x1080_scrot](https://user-images.githubusercontent.com/6642964/46391276-35d13880-c699-11e8-9c4a-62161c6840fa.png)
jmeline commented 5 years ago

Tests will be added probably after work later tonight.

anshumanv commented 5 years ago

Hey @jmeline thanks for looking this up, replied to your review. :+1: :smile:

anshumanv commented 5 years ago

This is amazing @jmeline! :100: :tada:

Can you just fix the tests so I merge this? :sweat_smile:

Totally amazing work here and thanks for your patience. :1st_place_medal:

jmeline commented 5 years ago

@anshumanv Of course 😸

anshumanv commented 5 years ago

I'm done with my traveling so I can get back real quick now! :rofl:

jmeline commented 5 years ago

All done @anshumanv