Setup a basic page for the webapp

anshumanv / evolutions-webapp

What? monferno is evolving!

https://evolutions.js.org

MIT License

17 stars 17 forks source link

Setup a basic page for the webapp #8

Closed collinsnji closed 6 years ago

collinsnji commented 6 years ago

Fixes #4

By submitting this pull request I confirm I've read and complied with the below declarations.

[x] I have tested the changes locally and they are functional.
[x] I ensure that I sent this pull request after being assigned to the corresponding issue.
[x] This pull request has a descriptive title. For example, Added/Fixed {Feature/Bug}, not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

anshumanv commented 6 years ago

Looks neat ! @collinsnji What I'm doubtful about is if we need the package-lock.json to be added to the commits ? I think that's a configuration file that's generated while building/running What are your views on this @sneakycr0w ?

sneakycrowllc commented 6 years ago

You shouldn’t. The dependencies will be in package.json.

Zachary E Sohovich Full Stack Web Developer https://sneakycr0w.com zach@sneakycr0w.com

On Oct 2, 2017, at 10:54 PM, Anshuman Verma notifications@github.com wrote:

Looks neat ! @collinsnji What I'm doubtful about is if we need the package-lock.json to be added to the commits ? I think that's a configuration file that's generated while building/running What are your views on this @sneakycr0w ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

anshumanv commented 6 years ago

Right, exactly. Apparently in this PR you have included package-lock. Please add another commit to remove it @collinsnji 😄 Also i think every other thing is in place, what say @sneakycr0w

collinsnji commented 6 years ago

Oh right. I did not noticed when I committed the package-lock file. I'll remove it

anshumanv commented 6 years ago

Thanks ! Actually i should've added that to .gitignore earlier 😅

collinsnji commented 6 years ago

Haha yeah. One more thing, how will the webapp be hosted? Heroku?

anshumanv commented 6 years ago

I don't have any such preference, what are your preferences on this ?

collinsnji commented 6 years ago

I think Heroku will be best for this :) @sneakycr0w what do you think?

anshumanv commented 6 years ago

Right, heroku sounds good to me. Let's hear from @sneakycr0w