search

anshumanv / react-poke-sprites

A react component that renders animated pokemon sprites.
MIT License
23 stars 5 forks source link

Nidoran male and female #5

Open Lisser opened 6 years ago

Lisser commented 6 years ago

Great component, thanks! Just checked gen 1, but Nidoran male and female don't work.

Id 29 and 32

anshumanv commented 6 years ago

Thanks for bringing this to light, I investigated the issue and it seems that one of the submodule which fetches gif links has a flawed name return - https://github.com/jackrzhang/pokemon-gif/blob/9a3d08786da13739c988d34144da58254d213720/lib/pokedex-number-to-name.js#L213

No gif returned for http://www.pokestadium.com/sprites/xy/nidoran.gif but returned for http://www.pokestadium.com/sprites/xy/nidoranf.gif http://www.pokestadium.com/sprites/xy/nidoranm.gif

anshumanv commented 6 years ago

29,32 after converting number to name is converted to nidoran which doesn't exist. It should be either nidoranm or nidoranf