search

ansible-collections / amazon.aws

Ansible Collection for Amazon AWS
GNU General Public License v3.0
310 stars 336 forks source link

route53: Return diff only when module._diff is true #2136

Closed GomathiselviS closed 3 months ago

GomathiselviS commented 3 months ago
SUMMARY

Refer https://issues.redhat.com/browse/ACA-1477 Route53 module, returns after and before diff as module output. This PR fixes this bug, by adding a check to return the diff only when module._diff is set to true.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
github-actions[bot] commented 3 months ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/0850a8af21b04a41a8e3344010b03142

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 52s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 26s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 12s :x: integration-amazon.aws-1 FAILURE in 7m 42s Skipped 43 jobs

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/92684c2fafef411698ee32889e362436

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 43s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 50s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 09s :x: integration-amazon.aws-1 FAILURE in 7m 07s Skipped 43 jobs

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/a428f0353d1d44c9bcd2e4ef82c38673

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 46s :heavy_check_mark: build-ansible-collection SUCCESS in 13m 03s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 34s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 34s Skipped 43 jobs

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/7c2ddc5d53a744e587167187f145c8c3

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 01s :heavy_check_mark: build-ansible-collection SUCCESS in 13m 19s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 15s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 00s Skipped 43 jobs

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/7f2fa77416bb4e9ebb1eb72a8c7da21b

:warning: ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection :x: build-ansible-collection RETRY_LIMIT Host unreachable in 1m 31s :x: ansible-test-splitter RETRY_LIMIT Host unreachable in 36s :warning: integration-amazon.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

GomathiselviS commented 3 months ago

regate

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/ef65cb05ebb540ada78ce532ea963095

:warning: ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection :x: build-ansible-collection RETRY_LIMIT Host unreachable in 5m 40s :x: ansible-test-splitter RETRY_LIMIT in 2m 11s :warning: integration-amazon.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

GomathiselviS commented 3 months ago

regate

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/739117776c2f441c892fcac719255d98

:warning: ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection :x: build-ansible-collection RETRY_LIMIT in 3m 48s :x: ansible-test-splitter RETRY_LIMIT in 4m 50s :warning: integration-amazon.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/dea06fcc354f48df9dc812ed15f91ace

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 39s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 13s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 15s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 20s Skipped 43 jobs

softwarefactory-project-zuul[bot] commented 3 months ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/bdf5b6787fb04397a78f665aa14086ab

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 13s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 10s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 09s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 29s Skipped 43 jobs

patchback[bot] commented 1 month ago

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/b56f70860804d424b02cce0509126f43c9d8f07a/pr-2136

Backported as https://github.com/ansible-collections/amazon.aws/pull/2260

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.