search

ansible-collections / amazon.aws

Ansible Collection for Amazon AWS
GNU General Public License v3.0
277 stars 321 forks source link

Use double back-ticks instead of single ones #2150

Closed alinabuzachis closed 4 days ago

alinabuzachis commented 5 days ago
SUMMARY

Use double back-ticks instead of single ones

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
github-actions[bot] commented 5 days ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul[bot] commented 5 days ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/07087608ff8946bab1cb909cbff137f6

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 36s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 09s

softwarefactory-project-zuul[bot] commented 4 days ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/f9cda2efcb3c490b81feee2058683b66

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 28s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 18s

patchback[bot] commented 4 days ago

Backport to stable-8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 19c4b0ae085a8fddb97a24a616aad8a4cccaecea on top of patchback/backports/stable-8/19c4b0ae085a8fddb97a24a616aad8a4cccaecea/pr-2150

Backporting merged PR #2150 into stable-7

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-8/19c4b0ae085a8fddb97a24a616aad8a4cccaecea/pr-2150 upstream/stable-8
  4. Now, cherry-pick PR #2150 contents into that branch: 
    $ git cherry-pick -x 19c4b0ae085a8fddb97a24a616aad8a4cccaecea

    If it'll yell at you with something like fatal: Commit 19c4b0ae085a8fddb97a24a616aad8a4cccaecea is a merge but no -m option was given., add -m 1 as follows instead:

    $ git cherry-pick -m1 -x 19c4b0ae085a8fddb97a24a616aad8a4cccaecea
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #2150 as close to the original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-8/19c4b0ae085a8fddb97a24a616aad8a4cccaecea/pr-2150
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.