ansible-collections / amazon.aws

Ansible Collection for Amazon AWS
GNU General Public License v3.0
277 stars 321 forks source link

A new workflow to ease pull request review by labelling them #2153

Closed abikouo closed 3 days ago

abikouo commented 3 days ago

This new workflow calculates the size of a pull request based on the additions and deletions and add a label corresponding to the size of the pull (XS, S, M, L, XL). This aims to ease pull request review

softwarefactory-project-zuul[bot] commented 3 days ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/395169b48b1948528629a1749940e031

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 36s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 50s

GomathiselviS commented 3 days ago

Hi @abikouo

Thank you for the effort you put into creating a GH workflow to ease PR review by labeling the PR based on its size. This is a fantastic step towards improving our review process.

However, I would like to note that while this workflow can inform the PR submitter about the need to break down large PRs, we should be cautious about relying solely on the formula used. The PR size should ideally reflect the complexity of the inserted and deleted lines, not just their count. The current formula may not fully capture this complexity.

Thank you again for your contribution. Your work is much appreciated, and this workflow will certainly help streamline our PR submission and review process. Can you add a proposal in the cloud-content-handbook and move the GH action to cloud-content-ci-automation repository?