search

ansible-collections / ansible-consul

:satellite: Ansible role for Hashicorp Consul clusters
https://galaxy.ansible.com/ansible-community/consul/
BSD 2-Clause "Simplified" License
456 stars 316 forks source link

Improvements for `var-spacing` in ansible-lint #541

Closed ppuschmann closed 1 year ago

ppuschmann commented 1 year ago

The rule was formerly known as jinja[spacing].

nre-ableton commented 1 year ago

@ppuschmann Thanks for responding to my comments. I'm really busy this week with a project that has a deadline before the Easter holidays, but I'll re-review your changes as soon as I can.

nre-ableton commented 1 year ago

CI problems have been fixed in https://github.com/ansible-community/ansible-consul/pull/547, but unfortunately that has led to some merge conflicts. Namely, the commit 84bb7cc6e19d0c8ee539262c47983825606152f0 ("Add pipefail to shell-tasks") must be dropped. See further explanation here as to why we sadly can't use set -o pipefail, if you are curious.

So please rebase and drop the commit, and I'll go ahead and merge this PR.

Normally I would rebase this branch myself to save you the trouble, but I don't want to force-push your branch and delete your commits, so I would prefer if you could do it. 👍 If you aren't sure how to rewrite the history and drop the commit, just give me your blessing and I'll take care of it.