search

ansible-collections / ansible-consul

:satellite: Ansible role for Hashicorp Consul clusters
https://galaxy.ansible.com/ansible-community/consul/
BSD 2-Clause "Simplified" License
452 stars 313 forks source link

Fix: fixed handlers to listen to proper notifiers #546

Closed xterr closed 1 year ago

xterr commented 1 year ago

Fix case for handlers

nre-ableton commented 1 year ago

I'm not sure why this PR is failing CI, I will rebase it (I can't tell from GitHub's UI whether it's based on the latest master).

xterr commented 1 year ago

I saw it as well. I checked the error messages from the pipeline but I didn’t saw anything relevant to this specific change.

As a suggestion, maybe you can create a new patch version as well?

I really appreciate your time for fixing this. Thank you

nre-ableton commented 1 year ago

There are other issues with CI, I'll try to sort them out this week.

nre-ableton commented 1 year ago

CI failures have been resolved in https://github.com/ansible-community/ansible-consul/pull/547. I'll rebase your branch and re-test.