search

ansible-collections / ansible-consul

:satellite: Ansible role for Hashicorp Consul clusters
https://galaxy.ansible.com/ansible-community/consul/
BSD 2-Clause "Simplified" License
452 stars 313 forks source link

Run ansible-lint in its own workflow #550

Closed nre-ableton closed 1 year ago

nre-ableton commented 1 year ago

This is in preparation for Molecule 5.x, which removes the lint command. For more information, see:

https://github.com/ansible-community/molecule/pull/3802

Aside from that, this approach is also a bit nicer since linter errors can be identified by their own GitHub checks run, which should be easier for developers compared to the previous approach of having to hunt through Molecule's error logs for linter errors. Also, it's a bit more efficient since we only run the linters once per CI run instead of in every Molecule scenario.

nre-ableton commented 1 year ago

Note: After https://github.com/ansible-community/ansible-consul/pull/541 is merged, we should be able to remove var-spacing that was added in 8aa884623366c5a097b6f9b81f4bef837e1500b4 for the purposes of making CI pass.

bbaassssiiee commented 1 year ago

We need another maintainer to review?

nre-ableton commented 1 year ago

We need another maintainer to review?

No, you just need to approve and I'll merge

nre-ableton commented 1 year ago

Looks good to me

Thanks!