Closed xFuture603 closed 7 months ago
This PR fixes some linting errors for the ansible-consul role, applied on Ansible version 2.14.
ansible-consul
I've used this version since ansible-core 2.14 is still supported (https://endoflife.date/ansible-core) and ansible-core 2.8 is unsupported.
Most notable changes:
systemd
ansible.builtin.systemd_service
file
ansible.builtin.import_tasks
I was not sure if ansible.windows can be removed as a requirement now, as it is replaced by community.windows in newer Ansible versions.
ansible.windows
community.windows
While testing locally with Molecule, I've encountered some errors like:
Command: molecule --base-config molecule/_shared/base.yml converge --scenario-name debian-11
molecule --base-config molecule/_shared/base.yml converge --scenario-name debian-11
Error:
Prepare stage: TASK [Install OS packages] ***************************************************** fatal: [localhost]: FAILED! => {"changed": false, "module_stderr": "sudo: a password is required\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}
So maybe someone can give me a little hint here.
Otherwise, I still hope that this PR will be reviewed and possibly successfully merged. Please write to me if there is anything missing in this PR!
Closed, because most of these changes are now covered in this PR: https://github.com/ansible-community/ansible-consul/pull/574
This PR fixes some linting errors for the
ansible-consul
role, applied on Ansible version 2.14.I've used this version since ansible-core 2.14 is still supported (https://endoflife.date/ansible-core) and ansible-core 2.8 is unsupported.
Most notable changes:
systemd
toansible.builtin.systemd_service
module (see: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/systemd_module.html and https://docs.ansible.com/ansible/latest/collections/ansible/builtin/systemd_service_module.html#ansible-collections-ansible-builtin-systemd-service-module)file
parameter foransible.builtin.import_tasks
(see: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/import_tasks_module.html#parameter-file)I was not sure if
ansible.windows
can be removed as a requirement now, as it is replaced bycommunity.windows
in newer Ansible versions.While testing locally with Molecule, I've encountered some errors like:
Command:
molecule --base-config molecule/_shared/base.yml converge --scenario-name debian-11
Error:
So maybe someone can give me a little hint here.
Otherwise, I still hope that this PR will be reviewed and possibly successfully merged. Please write to me if there is anything missing in this PR!