ansible-collections / ansible-consul

:satellite: Ansible role for Hashicorp Consul clusters
https://galaxy.ansible.com/ansible-community/consul/
BSD 2-Clause "Simplified" License
450 stars 313 forks source link

Fixed linting against ansible-core version 2.14 #573

Closed xFuture603 closed 7 months ago

xFuture603 commented 8 months ago

This PR fixes some linting errors for the ansible-consul role, applied on Ansible version 2.14.

I've used this version since ansible-core 2.14 is still supported (https://endoflife.date/ansible-core) and ansible-core 2.8 is unsupported.

Most notable changes:

I was not sure if ansible.windows can be removed as a requirement now, as it is replaced by community.windows in newer Ansible versions.

While testing locally with Molecule, I've encountered some errors like:

Command: molecule --base-config molecule/_shared/base.yml converge --scenario-name debian-11

Error:

Prepare stage:

TASK [Install OS packages] *****************************************************
fatal: [localhost]: FAILED! => {"changed": false, "module_stderr": "sudo: a password is required\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

So maybe someone can give me a little hint here.

Otherwise, I still hope that this PR will be reviewed and possibly successfully merged. Please write to me if there is anything missing in this PR!

xFuture603 commented 7 months ago

Closed, because most of these changes are now covered in this PR: https://github.com/ansible-community/ansible-consul/pull/574