search

ansible-collections / ansible.posix

Ansible Collection for Posix
Other
157 stars 152 forks source link

_new_stdin is deprecated, needs to be removed from synchronize module #468

Open jnm27 opened 1 year ago

jnm27 commented 1 year ago
SUMMARY

Getting this deprecation warning in the log; pretty sure it's coming from the synchronize module.

[DEPRECATION WARNING]: The connection's stdin object is deprecated. Call display.prompt_until(msg) instead. This feature will be removed in version 2.19. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
ISSUE TYPE
COMPONENT NAME

synchronize.py

ANSIBLE VERSION
ansible [core 2.15.0]
  python version = 3.11.2 (main, Feb 17 2023, 09:28:16) [GCC 8.5.0 20210514 (Red Hat 8.5.0-18)] (/usr/bin/python3.11)
  jinja version = 3.1.2
COLLECTION VERSION
ansible.posix 1.5.4
CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE
EXPECTED RESULTS

No deprecation warnings

ACTUAL RESULTS

Deprecation warnings

erwdavid commented 1 year ago

Confirm it comes from the synchronize module (got it with command ansible regulateur -m synchronize -a "src=/home/edavid/workshop/liquidprompt/ dest=/tmp/liquidprompt/" )

I get the deprecation warning on a ssh connexion, not for localhost.

heitorPB commented 1 year ago

I also confirm this warning on ansible core 2.15.1 and ansible.posix 1.5.4.

s-hertel commented 1 year ago

@maxamillion Can you take a look at the fix in https://github.com/ansible-collections/ansible.posix/pull/421? Not sure why I was getting different errors in CI, if it's just flaky or related in some way to my patch. I'll rerun them again.

donnieelmore commented 1 year ago

I am also seeing this on ansible core 2.15.2 and ansible.posix 1.5.4

[DEPRECATION WARNING]: DEFAULT_GATHER_TIMEOUT option, the module_defaults keyword is a more generic version and can apply to all calls to the M(ansible.builtin.gather_facts) or M(ansible.builtin.setup) actions,
use module_defaults instead. This feature will be removed from ansible-core in version 2.18. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
valli-org commented 1 year ago

Still present here in ansible-core 2.15.3 (ansible.posix 1.5.4): [DEPRECATION WARNING]: The connection's stdin object is deprecated. Call display.prompt_until(msg) instead. This feature will be removed in version 2.19. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

heitorPB commented 1 year ago

Apparently https://github.com/ansible-collections/ansible.posix/pull/421 fixes this. Who can review it to get merged?

fredbcode commented 11 months ago

Present in 2.15.5

[DEPRECATION WARNING]: The connection's stdin object is deprecated. Call display.prompt_until(msg) instead. This feature will be removed in version 2.19. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
fredbcode commented 4 months ago

I saw a merged fix, there is a plan to release soon ?