ansible-collections / ansible.posix

Ansible Collection for Posix
Other
159 stars 153 forks source link

review modules docs #545

Closed russoz closed 4 months ago

russoz commented 5 months ago
SUMMARY

Review the doc blocks of the modules in the collection.

ISSUE TYPE
COMPONENT NAME

plugins/modules/acl.py plugins/modules/at.py plugins/modules/authorized_key.py plugins/modules/firewalld.py plugins/modules/firewalld_info.py plugins/modules/mount.py plugins/modules/patch.py plugins/modules/rhel_facts.py plugins/modules/rhel_rpm_ostree.py plugins/modules/seboolean.py plugins/modules/selinux.py plugins/modules/synchronize.py plugins/modules/sysctl.py

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/039f5cc3bd394215a6c683d0a3af5a04

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 23s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 39s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/146e574863f74f138953de03907b9b52

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 15s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 10s

russoz commented 5 months ago

Hi there, the CI errors seem to be not related to the doc changes.

felixfontein commented 5 months ago

The two errors reported by ansible-lint should be added to its ignore list (there doesn't seem to be a config so far, that one has to be created then to ignore these two entries). The required ansible-core metadata check doesn't make much sense anyway from my point of view (I disable it everywhere where I use ansible-lint), and the other reported error is obviously bogus and the result of a bug in ansible-lint.

felixfontein commented 5 months ago

I created #546 to fix this.

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/8faaeb2105be4f6ba91a503a756a18e2

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 37s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 26s

yurnov commented 5 months ago

Could you please update rst files with 'collection_prep_add_docs -p /.' from collection_prep repo?

felixfontein commented 5 months ago

I would rather wipe these RST files from the repository. collection_prep does not support current Ansible markup, which this PR is using anyway.

russoz commented 5 months ago

I would rather wipe these RST files from the repository. collection_prep does not support current Ansible markup, which this PR is using anyway.

@yurnov per that comment, I am refraining from running that script. Is there anything else I need to do to make this PR ready for merging? TIA

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/f072d052b25640b4b0e18828288a6b7d

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 32s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 56s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/f9c615a449994dcf8ffad63fd836b471

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 00s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 09s

russoz commented 5 months ago

Rebasing...

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/65d5c60ce3aa4fd1adc090b980afa1ad

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 43s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 39s

russoz commented 4 months ago

@felixfontein do you have any idea how to release this "ansiblegate" in the CI?

felixfontein commented 4 months ago

@russoz that's triggered once someone with commit rights adds the mergeit label. Then Zuul will start that CI job, and merge once it succeeds.

softwarefactory-project-zuul[bot] commented 4 months ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/502eac7ea3ce4a479037c7c51998f4c0

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 35s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 52s