ansible-collections / ansible.posix

Ansible Collection for Posix
Other
157 stars 152 forks source link

Add basic ansible-lint config to fix CI; add ansible-core 2.17 to CI #546

Closed felixfontein closed 4 months ago

felixfontein commented 4 months ago
SUMMARY

ansible-lint makes the nightly CI fail (https://dev.azure.com/ansible/ansible.posix/_build/results?buildId=114105&view=logs&j=2671e6a6-f41a-533c-2720-8ffdcf8ab96f&t=5b604a49-baaa-558f-6ab2-4a2ff646af4f) due to two rules:

Also adds sanity ignore file for ansible-core 2.18 (the version used by the current devel branch).

ISSUE TYPE
COMPONENT NAME

ansible-lint in CI

felixfontein commented 4 months ago

Ref: https://github.com/ansible/ansible-lint/issues/4160 (for fqcn[deep])

softwarefactory-project-zuul[bot] commented 4 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/c95e60a4fa82405ab910b7b14fbe1e7a

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 50s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 58s

russoz commented 4 months ago

It looks like tests are not using ansible-core 2.17?

felixfontein commented 4 months ago

Indeed, they don't. I'll push a commit that changes that as well.

softwarefactory-project-zuul[bot] commented 4 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/270073e63c3e4de2a008449348ce9520

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 56s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 59s

softwarefactory-project-zuul[bot] commented 4 months ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/c9625be7e9e348ea95536e0c298d2b49

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 24s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 06s

felixfontein commented 4 months ago

@russoz @maxamillion thanks a lot for reviewing and merging!