djgraff209
commented
4 years ago The code on this was bugging me and I woke up with a thought on this.
Could this be changed from:
# Determine if we need a user@
user = None
if not dest_is_local:
# Src and dest rsync "path" handling
if boolean(_tmp_args.get('set_remote_user', 'yes'), strict=False):
if use_delegate:
user = task_vars.get('ansible_delegated_vars', dict()).get('ansible_ssh_user', None)
if not user:
user = task_vars.get('ansible_ssh_user') or self._play_context.remote_user
if not user:
user = C.DEFAULT_REMOTE_USER
else:
user = task_vars.get('ansible_ssh_user') or self._play_context.remote_userTo:
# Determine if we need a user@
user = None
if not dest_is_local:
# Src and dest rsync "path" handling
if boolean(_tmp_args.get('set_remote_user', 'yes'), strict=False):
if use_delegate:
delegated_task_vars = task_vars.get('ansible_delegated_vars', dict())
user = delegated_task_vars.get('ansible_user') or delegated_task_vars.get('ansible_ssh_user')
if not user:
user = task_vars.get('ansible_user') or task_vars.get('ansible_ssh_user') or self._play_context.remote_user
if not user:
user = C.DEFAULT_REMOTE_USER
else:
user = task_vars.get('ansible_user') or task_vars.get('ansible_ssh_user') or self._play_context.remote_user
The key pieces being to check for 'ansible_user' in preference to 'ansible_ssh_user'. My suggestion on this to also create a delegated_task_vars variable local to this section to reduce lookups.
quidame
Akasurde
From @djgraff209 on Jun 23, 2020 22:12
SUMMARY
The Ansible 'synchronize' refers to the deprecated 'ansible_ssh_user' variable exclusively without taking into account the 'ansible_user' (2.9+) variable.
ISSUE TYPE
COMPONENT NAME
synchronize
ANSIBLE VERSION
CONFIGURATION
OS / ENVIRONMENT
Controller: MacOS Catalina 10.15.5 / Python3 3.8.2 Target Node Set: 8 nodes running Redhat 7.7 1 node running CentOS 7.7
STEPS TO REPRODUCE
Assume following:
Provide a playbook to synchronize between a RedHat and CentOS
EXPECTED RESULTS
Expect that synchronize plugin will copy redhat@host1:/some/directory/somefile.tar.gz to centos@host2:/tmp/somefile.tar.gz using rsync command delegated to host1.
ACTUAL RESULTS
Task fails to copy indicating too many authentication attempts.
NB - I updated my inventory adding
ansible_ssh_userto matchansible_useron host2 and the operation succeededDigging through the source https://github.com/ansible/ansible/blob/stable-2.9/lib/ansible/plugins/action/synchronize.py#L320
This section appears to need some care & feeding to consider
ansible_userCopied from original issue: ansible/ansible#70248