Fix 496 - remove string substitution

[TheRealBecks]

Fixes #496

SUMMARY

- have been wrongly replaced by _ in port_protocol causing dictionary key comparisons.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

eos_acls

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (58e5fe6) 82.76% compared to head (237cd31) 82.87%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #502 +/- ## ========================================== + Coverage 82.76% 82.87% +0.11% ========================================== Files 153 153 Lines 11967 11966 -1 ========================================== + Hits 9904 9917 +13 + Misses 2063 2049 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[softwarefactory-project-zuul[bot]]

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/d44013e909c649b5a943b226edc7c8b9

:heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable215 SUCCESS in 42m 08s :heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable214 SUCCESS in 41m 13s :heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable213 SUCCESS in 35m 18s :heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable212 SUCCESS in 37m 51s :x: ansible-test-network-integration-eos-httpapi-python39-stable211 RETRY_LIMIT in 1m 10s :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable215-scenario01 SUCCESS in 33m 30s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable215-scenario02 FAILURE in 33m 20s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable215-scenario01 SUCCESS in 34m 09s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable215-scenario02 RETRY_LIMIT in 1m 19s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable214-scenario01 SUCCESS in 32m 14s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable214-scenario02 RETRY_LIMIT in 1m 51s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable214-scenario01 SUCCESS in 31m 44s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable214-scenario02 FAILURE in 35m 43s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable213-scenario01 SUCCESS in 31m 15s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable213-scenario02 FAILURE in 37m 28s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable213-scenario01 SUCCESS in 32m 19s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable213-scenario02 FAILURE in 37m 25s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable212-scenario01 SUCCESS in 31m 40s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable212-scenario02 FAILURE in 33m 50s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable212-scenario01 SUCCESS in 32m 33s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable212-scenario02 RETRY_LIMIT in 1m 09s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable211-scenario01 SUCCESS in 32m 59s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable211-scenario02 FAILURE in 35m 28s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable211-scenario01 SUCCESS in 33m 07s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable211-scenario02 FAILURE in 32m 49s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 9m 49s :heavy_check_mark: ansible-tox-linters SUCCESS in 12m 00s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 24s

[TheRealBecks]

The ACL tests for IPv6 fail:

Unsupported parameters for (basic.py) module: config.acls.aces.protocol_options.icmpv6.reject-route.

Supported parameters include: [...] reject_route [...]

The device IPv6 commands will be parsed as dictionary keys with an underscore. Therefore my fix isn't working. Back to the drawing board...

[github-actions[bot]]

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

[TheRealBecks]

@rohitthakur2590 I don't think that it's possible or even good to merge my PR as there are several open issues with the eos_acls module. It looks like that there are three (?) sections that need a rewrite to address all issues at once. Also several test cases are missing.

I would like to add a new parent issue to collect all issues for that module (...there are also issues that have no issue report, yet...). From there on we can discuss how to proceed. Do you also think that that would be a good way to go?

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b3d41a9a199e44648bb74c6d9648ffe7

:heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable215 SUCCESS in 45m 13s :heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable214 SUCCESS in 45m 22s :heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable213 SUCCESS in 40m 35s :heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable212 SUCCESS in 40m 04s :heavy_check_mark: ansible-test-network-integration-eos-httpapi-python39-stable211 SUCCESS in 40m 36s :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable215-scenario01 SUCCESS in 36m 48s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable215-scenario02 FAILURE in 39m 04s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable215-scenario01 RETRY_LIMIT in 4m 16s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable215-scenario02 FAILURE in 34m 34s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable214-scenario01 RETRY_LIMIT in 4m 29s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable214-scenario02 FAILURE in 41m 13s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable214-scenario01 SUCCESS in 36m 50s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable214-scenario02 FAILURE in 38m 24s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable213-scenario01 SUCCESS in 38m 39s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable213-scenario02 FAILURE in 34m 47s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable213-scenario01 SUCCESS in 32m 50s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable213-scenario02 FAILURE in 36m 52s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable212-scenario01 SUCCESS in 33m 04s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable212-scenario02 FAILURE in 33m 08s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable212-scenario01 SUCCESS in 37m 37s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable212-scenario02 FAILURE in 34m 40s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-python39-stable211-scenario01 SUCCESS in 34m 08s (non-voting) :x: ansible-test-network-integration-eos-network_cli-python39-stable211-scenario02 FAILURE in 36m 03s (non-voting) :heavy_check_mark: ansible-test-network-integration-eos-network_cli-libssh-python39-stable211-scenario01 SUCCESS in 35m 20s (non-voting) :x: ansible-test-network-integration-eos-network_cli-libssh-python39-stable211-scenario02 FAILURE in 34m 54s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 10m 40s :heavy_check_mark: ansible-tox-linters SUCCESS in 12m 31s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 51s

[rohitthakur2590]

@TheRealBecks I agree! Let's open one separate issue for ACLS and mention all the acls specifics issues in that for the sake of better tracking.