fix(eos_config): change value validationfor parameter diff_against with value validate_config

philippebureau commented 7 months ago

SUMMARY

fixes #501

changing the value against what the module test for "replace" to append "rollback clean-config"

The previous behaviour was causing the module not to append "rollback clean-config" with method "get_session_config"

The returned "after" value was a sum of running-config + intended_config which makes the diff between before and after innacurate

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

eos_config / diff_against

ADDITIONAL INFORMATION

change the replace conditional value check to allows the returned "after" value to show the actual intended config and not a merge of intended and running-config

philippebureau commented 7 months ago

ready to review

softwarefactory-project-zuul[bot] commented 7 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/fab331f9d2864df397ffb97ac163cd60

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.76%. Comparing base (c1950c9) to head (6d25a6f).

:exclamation: Current head 6d25a6f differs from pull request most recent head 8872830. Consider uploading reports for the commit 8872830 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #503 +/- ## ======================================= Coverage 82.76% 82.76% ======================================= Files 153 153 Lines 11967 11967 ======================================= Hits 9904 9904 Misses 2063 2063 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/59947bccc03c4b4da9af25e9507daf2e

rohitthakur2590 commented 6 months ago

@philippebureau Thank for the contribution. Could you please changelog and test it if possible?

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/53b0a9402c93407eb5431d34eb16597c

philippebureau commented 6 months ago

@philippebureau Thank for the contribution. Could you please changelog and test it if possible?

done

rohitthakur2590 commented 5 months ago

@philippebureau This looks good, thanks for adding the changelog, could you please also add the integration test, you can add one more task in this file and have an assertion for the result.

philippebureau commented 5 months ago

the

@philippebureau This looks good, thanks for adding the changelog, could you please also add the integration test, you can add one more task in this file and have an assertion for the result.

the diff_against already had a an integration test. here

The assertion in the current test is valid.

Does the test need to be extended?

softwarefactory-project-zuul[bot] commented 4 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/5ef69cab5d43417bb1b7a1ee7ee03b79

philippebureau commented 1 month ago

@cidrblock as per discussed today at Redhat summit

ansible-collections / arista.eos