ansible-collections / cisco.ios

Ansible Network Collection for Cisco IOS
GNU General Public License v3.0
261 stars 162 forks source link

[ios_acls] add fix to standalone remarks #1044

Closed KB-perByte closed 1 month ago

KB-perByte commented 1 month ago
SUMMARY

The module now treats all the remarks for each ace as a block.

  1. every time a remark for an ace (with sequence) is updated the module would remove all the remarks for that ace entry by no <sequence> remark and add all the remarks back, as it is the only possible way to preserve the remarks order.
  2. Whenever an ace entry is updated it is removed first, which removes all the subordinate remarks. So we explicitly add the remarks back to maintain consistency and add back the ace entry.
  3. There is no line-by-line deletion of remarks entries, for every negation-specific action state remarks are removed as a whole and then added back.
ISSUE TYPE
COMPONENT NAME

ios_acls

ADDITIONAL INFORMATION
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.91%. Comparing base (9bb7b30) to head (1022dcb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1044 +/- ## ========================================== + Coverage 86.87% 86.91% +0.04% ========================================== Files 197 197 Lines 12111 12116 +5 ========================================== + Hits 10521 10531 +10 + Misses 1590 1585 -5 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/ansible-collections/cisco.ios/pull/1044/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections)
softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/12e5b17deaa3464fb9c0f9735eec8e0f

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 16s :heavy_check_mark: build-ansible-collection SUCCESS in 11m 53s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 12s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 45s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 12s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 23s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 31s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 37m 18s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 16s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 38s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 12m 21s

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/60744ea0bb0a4b48939020e3fe1175c0

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 05s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 56s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 22s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 18m 07s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 08s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 34s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 53s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 39m 45s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 16s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 6m 08s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 12m 07s

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/f227a47b01f34136bb74dcd00abb2a7a

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 17s :heavy_check_mark: build-ansible-collection SUCCESS in 16m 47s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 28s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 30s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 18s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 25s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 14s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 39m 12s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 42s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 28s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 22m 12s