[bgp_address_family] bug fix and optimisation

[KB-perByte]

SUMMARY

bgp_address_family fix & deprecate wrong attribute types, add missing attributes implementations, correct parsers and improve test coverage for the module.

Fixes -

• Aliased aggregate_address to aggregate_addresses that supports a list of dict attributes (same as bgp_global).
• Aliased neighbor to neighbors that supports a list of dict attributes (same as bgp_global).
• Aliased network to networks that supports a list of dict attributes (same as bgp_global).
• Deprecate slow_peer with slow_peer_options which supports a dict attribute.
• Deprecate neighbors.address/tag/ipv6_adddress with neighbor_address which enables common attributes for facts rendering (same as bgp_global).
• Deprecate neighbors.route_map with route_maps which supports list of dict attributes.
• Deprecate neighbors.prefix_list with prefix_lists which supports list of dict attributes.
• Deprecate neighbors.password with password_options which allows encryption and password.

Bugfixes -

• Added bmp.server_options.
• neighbors.path_attribute to support float format.
• Fix filter list to render correct config.
• Facts and config code optimized for using rm_templates

Features -

• Added neighbors.advertise
• Added network.evpn
• Added set attributes under redistribute options
• Added parses and config code for
• • aggregate-address
• • auto-summary
• • non-implimented attributes under bgp
• • distribute-lists
• Parsers added for non-implemented attributes

ISSUE TYPE

• Bugfix Pull Request
• Feature Pull Request

COMPONENT NAME

ios_bgp_address_family

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Unable to update github.com/ansible-collections/cisco.ios

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 54s :heavy_check_mark: build-ansible-collection SUCCESS in 3m 56s :x: ansible-ee-integration-ios-latest NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 13s (non-voting) :x: ansible-ee-integration-ios-libssh-latest NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 41m 25s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 4m 59s

[softwarefactory-project-zuul[bot]]

Build failed.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 05s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 01s :x: ansible-ee-integration-ios-latest NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 33s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 15m 29s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 42m 42s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 1h 24m 59s (non-voting) :x: ansible-tox-linters FAILURE in 5m 15s

[softwarefactory-project-zuul[bot]]

Build failed.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 49s :heavy_check_mark: build-ansible-collection SUCCESS in 3m 55s :x: ansible-ee-integration-ios-latest FAILURE in 13m 44s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 POST_FAILURE in 14m 11s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 09s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 43m 03s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 39m 35s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 55m 55s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 44m 04s (non-voting) :x: ansible-tox-linters FAILURE in 4m 58s

[softwarefactory-project-zuul[bot]]

Build failed.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 09s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 44s :x: ansible-ee-integration-ios-latest FAILURE in 17m 33s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 18m 36s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 16m 43s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 45m 07s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 42m 56s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 44m 54s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 46m 13s (non-voting) :x: ansible-tox-linters FAILURE in 5m 23s

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 59s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 52s :x: ansible-ee-integration-ios-latest NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 FAILURE in 15m 09s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 57s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 45m 30s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 40m 21s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 44m 33s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 NODE_FAILURE in 0s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 5m 13s

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 11s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 06s :x: ansible-ee-integration-ios-latest FAILURE in 14m 17s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 45s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 15m 57s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 45m 27s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 42m 19s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 45m 20s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 44m 45s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 5m 06s

[KB-perByte]

Module	statements	missing	excluded	branches	partial	coverage
plugins/module_utils/network/ios/argspec/bgp_address_family/init.py	0	0	0	0	0	100%
plugins/module_utils/network/ios/argspec/bgp_address_family/bgp_address_family.py	5	0	0	0	0	100%
plugins/module_utils/network/ios/config/bgp_address_family/init.py	0	0	0	0	0	100%
plugins/module_utils/network/ios/config/bgp_address_family/bgp_address_family.py	131	4	0	106	4	97%
plugins/module_utils/network/ios/facts/bgp_address_family/init.py	0	0	0	0	0	100%
plugins/module_utils/network/ios/facts/bgp_address_family/bgp_address_family.py	47	1	0	18	2	95%
plugins/module_utils/network/ios/rm_templates/bgp_address_family.py	11	0	0	0	0	100%
plugins/modules/ios_bgp_address_family.py	15	1	0	2	1	88%
tests/unit/modules/network/ios/test_ios_bgp_address_family.py	93	0	0	0	0	100%
Total	302	6	0	126	7	97%

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 10s :heavy_check_mark: build-ansible-collection SUCCESS in 3m 58s :x: ansible-ee-integration-ios-latest FAILURE in 14m 16s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 45s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 24s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 15m 21s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 44m 10s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 43m 33s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 NODE_FAILURE in 0s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 5m 03s

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 10s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 22s :x: ansible-ee-integration-ios-latest NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 FAILURE in 18m 19s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-latest NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 47m 08s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 NODE_FAILURE in 0s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 5m 09s

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 31s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 31s :x: ansible-ee-integration-ios-latest FAILURE in 16m 17s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 16m 29s (non-voting) :x: ansible-ee-integration-ios-libssh-latest NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 44m 49s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 44m 13s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 5m 11s

[netexgb]

Hi @KB-perByte @bentole On what version of cisco.ios will we se the fix? I just tested with 4.0.0 and it is still not working

[KB-perByte]

hey @netexgb you must find the changes in 4.1.0 ref Regards