Closed roverflow closed 6 months ago
Merging #963 (d17bf27) into main (8951167) will not change coverage. The diff coverage is
n/a
.
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/be77bfba0b0c4b15a3c4e20800b3cfc5
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 59s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 53s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 16s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 07s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 5m 43s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 10s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 20s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 19m 26s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 27s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 28s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 39s
Hey @roverflow size is a valid parameter
foo#ping ?
WORD Ping destination address or hostname
ancp ANCP echo
clns CLNS echo
ethernet Ethernet echo
ip IP echo
ipv6 IPv6 echo
srb srb echo
tag Tag encapsulated IP echo
vrf Select VPN routing instance
<cr> <cr>
foo#ping 8.8.8.8 ?
Extended-data specify extended data pattern
data specify data pattern
df-bit enable do not fragment bit in IP header
dscp Specify DSCP value in ASCII/Numeric
egress Force egress interface bypassing routing
ingress LAN source interface for Ingress
repeat specify repeat count
size specify datagram size
source specify source address or name
timeout specify timeout interval
tos specify type of service value
validate validate reply data
<cr> <cr>
foo#ping 8.8.8.8 size ?
<36-18024> Datagram size
We missed the attribute during our re-write, could you please look into it and consider the missing attribute as an implementation? Regards
ref : https://github.com/ansible-collections/cisco.ios/pull/595/files#diff-105f4bb6f132265a3e2f631c29eef96876f4e0a38ff634f9430969f612009191L52 This was missed when ping was re-implemented. We would need to fix it.
@roverflow The module documentation needs to change too! :D
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b91f5a0c13da44239b148748ed34403b
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 52s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 51s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 5m 54s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 29m 31s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 5m 16s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 5m 14s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 5m 19s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 29m 10s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 17m 01s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 6m 56s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 13m 25s
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/ab4c7fcf15af48b0895efe6315eab725
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 04s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 55s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 21s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 19m 38s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 19s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 23s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 23s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 19m 41s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 29s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 5m 06s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 44s
When could we expect a release that incorporates this change? I will have to revert our collection to a release prior to the rewrite to restore functionality to one of our most used playbooks due to this issue.
SUMMARY
Added the size param to ping module which previously did not exist
ISSUE TYPE
COMPONENT NAME
ios_ping.py