Fixes multiple ios_user bugs

[roverflow]

SUMMARY

Fixed a bug which did not set type 7 password and type 9 secret correctly. Fixed an issue where the ssh users were not being removed correctly on purge.

fixes issue - #950 #949

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ios_user.py

[codecov[bot]]

Codecov Report

Merging #970 (5c63c08) into main (d56c1c6) will decrease coverage by 0.01%. The diff coverage is n/a.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #970 +/- ## ========================================== - Coverage 86.79% 86.78% -0.01% ========================================== Files 196 196 Lines 12223 12237 +14 ========================================== + Hits 10609 10620 +11 - Misses 1614 1617 +3 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/ansible-collections/cisco.ios/pull/970/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections)

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/d2c4530c9d194c76a8f75d94a991365e

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 07s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 47s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 46s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 20m 44s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 40s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 5m 14s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 58s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 16m 07s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 24s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 5m 07s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 47s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/0c6f4c50a9334f4c8c9e300a938e327f

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 45s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 51s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 11s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 59s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 25s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 10m 44s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 25s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 43s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 36s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 14s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 31s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/fc7a9debde9e49d9b969289665a85056

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 19s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 54s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 25s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 06s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 13s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 03s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 03s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 06s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 52s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 26s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 48s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/7af68624346c4684882ad114114b7454

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 23s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 32s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 6m 04s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 16s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 6m 55s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 6m 39s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 6m 30s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 49s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 5m 05s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 7m 04s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 12m 31s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/7954259a5d45427daf9e570d9ebfa54e

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 33s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 12s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 29s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 19s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 13s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 09s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 5m 32s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 31s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 59s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 5m 21s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 12m 23s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/300529a85c7548f39ef0382b83c19bfc

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 44s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 45s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 05s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 21m 24s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 58s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 5m 02s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 13s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 20m 19s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 5m 07s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 19s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 53s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/8cbbf5c02ef843cc85baf0c4912153dd

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 34s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 50s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 09s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 57s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 07s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 18s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 22s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 17s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 56s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 03s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 44s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/23739fc6292d412dbfb07f4e3624df47

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 34s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 48s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 04s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 35s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 23s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 29s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 35s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 52s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 21s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 16s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 37s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/ddf59cd0dd404b3a881ac9fd16246a17

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 47s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 57s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 08s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 26s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 16s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 07s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 12s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 06s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 05s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 30s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 34s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/df1182ec3adf45c3b6f0f868c092b64e

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 01s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 44s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 37s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 RETRY_LIMIT in 3m 43s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 41s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 5m 02s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 5m 02s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 RETRY_LIMIT in 3m 45s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 5m 02s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 5m 11s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 34s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/25b64c0c7a154e96971785dd7d0375d4

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 18s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 52s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 5m 42s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 20m 35s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 13s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 24s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 5m 11s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 20m 30s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 14s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 10s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 23s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/4d5c2711ebb948269247f8ba758db6f1

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 15s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 49s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 18s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 20s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 19s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 19s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 06s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 30s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 20s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 53s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 41s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/75f9bb3efe6747fbbba5b21c38aff673

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 42s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 07s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 08s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 01s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 31s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 17s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 48s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 40s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 08s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 20s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 16s

[rowco]

@KB-perByte - This commit has re-introduced the issue that was resolved by #889. The regex in the terminal plugin ios.py is far too wide. In my case 'show run' is failing because we have the string 'Error:' in the config.

[KB-perByte]

Cc @roverflow

[roverflow]

Cc @roverflow

Will take a look!

[rowco]

Cc @roverflow

Will take a look!

@roverflow - any update on this?