ansible-collections / cisco.ios

Ansible Network Collection for Cisco IOS
GNU General Public License v3.0
262 stars 161 forks source link

ios_acls - make sequence optional for rendering of standard acls. #983

Closed KB-perByte closed 6 months ago

KB-perByte commented 6 months ago
SUMMARY

The collection supports cisco ios xe 17.x The acls facts are processed on the basis of the show running-config | section access-list command The command is updated replacing show access-lists command in order to incorporate the functionality of remarks, as native IOS XE supports it with the ios_acls module. In an older EOL'd version of ios 15.x, the command does not render any sequence number, essential for the module to process. If support for older iosxe versions are needed it is advised to use cisco.ios 5.1.0

host15v#show running-config | section access-list
ip access-list standard SNMP_sec
 permit 10.255.236.0 0.0.3.255

In a supported appliance version, ios xe 17.x

foo#show running-config | section access-list
ip access-list standard SNMP-sec
 10 permit 10.255.236.0 0.0.3.255

The sequence check in facts processing is relaxed, not extending support for EOL'd versions of IOS.

ISSUE TYPE
COMPONENT NAME

ios_acls

ADDITIONAL INFORMATION
codecov[bot] commented 6 months ago

Codecov Report

Merging #983 (0311fb7) into main (8e932e5) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #983 +/- ## ======================================= Coverage 86.44% 86.44% ======================================= Files 202 202 Lines 12766 12766 ======================================= Hits 11036 11036 Misses 1730 1730 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/ansible-collections/cisco.ios/pull/983/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections)
snehald12 commented 5 months ago

Hello Team,

Can someone please confirm the collection version this issue is fixed in? The customer who is facing the issue error "module_stderr": "unhashable type: 'dict'" when using range in port_protocol is using cisco.iso 5.2.0.

Thanks.

roverflow commented 5 months ago

@snehald12, i believe this issue is addressed in version 5.3.0, the most recent release is 6.0.0.