Some fixes in ios_acls module:

[earendilfr]

SUMMARY

Some modification done:

• Currently, when we push an ACL from a type (extended or standard) but an ACL from the other type is present, module dones't delete first the previous ACL. So, we could have an error because the ACL are not compatible. The only solution was first delete the previous ACL completely

• For the version IOS-XE 16.9 and for all the IOS 15.x, the ACE didn't have the sequence number. I fixe was previously done by @KB-perByte but I suspect that something still not working. It's better with:

  • added the ^\s* prior both line for ace
  • replace the count variable in config/acls/acls.py by a enumerate function

• At the same point, I have check the unit test test_ios_acls_parsed_matchesand I think that an "ugly" workaround was put in place to take in count that the ACE was not correctly matched and so, in test, the address object was replaced by a protocol_option object...

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ios_acls

ADDITIONAL INFORMATION

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f4084f2) 86.74% compared to head (3db7186) 86.74%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #998 +/- ## ========================================== - Coverage 86.74% 86.74% -0.01% ========================================== Files 197 197 Lines 12067 12081 +14 ========================================== + Hits 10468 10480 +12 - Misses 1599 1601 +2 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/ansible-collections/cisco.ios/pull/998/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections)

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/1ee858876ee3484cbf17cb22877c884d

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 32s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 52s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 40s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 57s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 13s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 5m 00s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 33s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 47s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 39s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 13s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 35s

[KB-perByte]

Hey @earendilfr, I look forward to merging this in upcoming releases, Thank you for your contribution. Please note - the maximum version of IOS-XE supported by the collection is 17.x, any change native to an older version of IOS would not be considered. Reagrds

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/f91cfaf06f464e1c850e49a7fb829b53

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 40s :heavy_check_mark: build-ansible-collection SUCCESS in 11m 02s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 57s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 18s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 40s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 00s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 27s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 16m 16s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 02s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 58s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 51s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/c9ac74455da34b818f6b2a36d8fa254f

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 56s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 37s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 17s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 22s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 54s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 17s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 19s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 50s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 20s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 58s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 33s

[KB-perByte]

@earendilfr can you please look at the conflicts? I see you have added some tests, we can get it reviewed.

CC @roverflow

[earendilfr]

@KB-perByte , @roverflow : I have perform the merge and the tests (for ACL module) working fine. Concerning the unit test added: I remember I have just added a test to simulate the add of an ACL with the same name but a different type than an already existing ACL.

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/9812b170ea854b9aba85e8177d5025f7

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 05s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 49s :x: ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 01s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 53s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 07s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 15s (non-voting) :x: ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 14s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 26s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 2m 58s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 08s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 35s