search

ansible-collections / cisco.iosxr

Ansible Network Collection for Cisco IOSXR
GNU General Public License v3.0
69 stars 48 forks source link

Set netcommon dependency to 4.1.0 on 4.1.0 release #354

Closed sean-m-sullivan closed 1 year ago

sean-m-sullivan commented 1 year ago
SUMMARY

Not sure how to fix this, but ran into this earlier today. If you run Cisco 4.1.0, and Netcommon 5.0.0, you run into an error.

Basically you get the error that https://github.com/ansible-collections/cisco.iosxr/blob/4976040a5718af5da4d2ced06b3cd7dd71b49e4e/plugins/module_utils/network/iosxr/utils/utils.py#L18 No longer can be imported, as it was updated in the net common breaking changes that the reference has moved https://github.com/ansible-collections/ansible.netcommon/blob/main/CHANGELOG.rst#breaking-changes-porting-guide such as

ImportError: cannot import name 'is_masklen' from 
'ansible_collections.ansible.netcommon.plugins.module_utils.network.common.utils'

Was thinking a 4.1.1 should be released with the https://github.com/ansible-collections/cisco.iosxr/blob/4976040a5718af5da4d2ced06b3cd7dd71b49e4e/galaxy.yml#L5 set to netcommon less then 5.

If its agreed to I can make the PR, but wanted to start a discussion if this is the right way to go about it.

ISSUE TYPE
COMPONENT NAME

Dependency???

ANSIBLE VERSION
2.14.3
COLLECTION VERSION
4.1.0
ashwini-mhatre commented 1 year ago

@sean-m-sullivan could you please update cisco.iosxr version to 5.0.0 which will fix this issue

sean-m-sullivan commented 1 year ago

I did, I was more thinking of those who have not.

We had been importing from this collection to do additional fact gathering, and had to figure it out as 5.0.0 is not on certified hub yet

But just checked, it is now

ashwini-mhatre commented 1 year ago

should i close this issue?