[bug] Fix Salt 6->8 Chars

ansible-collections / cisco.nxos

Ansible Network Collection for Cisco NXOS

GNU General Public License v3.0

115 stars 109 forks source link

[bug] Fix Salt 6->8 Chars #758

Open vvas1lev opened 1 year ago

vvas1lev commented 1 year ago

SUMMARY

The NXOS Salt is 8 Chars, not 6.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cisco.nxos.nxos_user

ADDITIONAL INFORMATION

Tested on NX-OS:

version 6.0(2)U5(2) version 7.0(3)I7(9)

XXX(config)# username test password test username test password 5 $1$.i0lhsgi$8suX0ENNqXqQ4Mp22qPKQ/ role network-operator XXX(config)# do sh run | incl test username test password 5 $1$.i0lhsgi$8suX0ENNqXqQ4Mp22qPKQ/ role network-operator

BEFORE
fatal: [XXX]: FAILED! => {"changed": false, "msg": "Provided hash is not valid"}

AFTER
XXX : ok=1    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

softwarefactory-project-zuul[bot] commented 1 year ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/64814706fded464ca9bc68544d099537

softwarefactory-project-zuul[bot] commented 11 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/ff07c5932d8b421dbc1e1d84de6c8327

softwarefactory-project-zuul[bot] commented 11 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/737b96e49fbc4065b2fab2642409148b

vvas1lev commented 11 months ago

@NilashishC, could you take a look at this PR?

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.72%. Comparing base (36066cd) to head (6fff01e). Report is 16 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #758 +/- ## ========================================== - Coverage 84.77% 84.72% -0.05% ========================================== Files 215 215 Lines 18360 18394 +34 ========================================== + Hits 15564 15584 +20 - Misses 2796 2810 +14 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/ansible-collections/cisco.nxos/pull/758/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections)

softwarefactory-project-zuul[bot] commented 8 months ago

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging github.com/ansible-collections/cisco.nxos for 758,3e95efefc6ca42256a6bc5ce0b9af9108ef5f118

softwarefactory-project-zuul[bot] commented 8 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b701d13db84f4795bf9d61535ad2b08e

vvas1lev commented 8 months ago

@NilashishC - this PR is related to a bug; I don't have triage access to be able to apply a label. I've updated the change log.

softwarefactory-project-zuul[bot] commented 8 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/cfd39742565044338a70fb05cb5743a4

softwarefactory-project-zuul[bot] commented 8 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/ebdbf765c8d94258b9726710c9446300

softwarefactory-project-zuul[bot] commented 8 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/105c9e3bb4154a0aa93d49cc9c11b42e