Add to_text for vrf names

[wormley]

SUMMARY

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

cisco.nxos.nxos_bgp_global

ADDITIONAL INFORMATION

The cisco.nxos.nxos_bgp_global suffers the same edge case as was fixed in snmp last year. If there are mixed vrf names some having all digits and some having letters the same error occurs in sorted() when it tries to compare int to string. This is the same code change as was done in snmp_server.

This proposed change may cause some issue for anyone using purely numeric vrf names as "9" will now sort after "10" and the section will be re-ordered.

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/8aa39b9f057d434293c1cb3268b17cd3

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 12s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 46s :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 01s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 04s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 17s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 51s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 34m 43s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 34m 42s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 41m 24s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 34m 39s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 35m 55s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 33m 30s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 41m 11s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 08s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 34m 12s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 26s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 40m 16s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 32m 05s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 10m 19s

[codecov[bot]]

Codecov Report

Merging #772 (7676341) into main (d7fcc2d) will increase coverage by 0.00%. The diff coverage is n/a.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #772 +/- ## ======================================= Coverage 85.01% 85.01% ======================================= Files 211 211 Lines 18230 18231 +1 ======================================= + Hits 15498 15499 +1 Misses 2732 2732 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/ansible-collections/cisco.nxos/pull/772/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections)

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/a0fa436685994789800a66563ad8e998

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 40s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 37s :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 54s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 22s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 35s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 49s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 35m 09s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 35m 33s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 41m 13s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 33m 10s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 35m 05s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 34m 20s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 42m 05s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 48s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 33m 50s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 05s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 40m 40s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 31m 39s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 10m 19s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/9b5c3579943c47ae8259c296d1407f6e

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 42s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 49s :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 40s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 30s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 38m 49s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 29m 42s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 36m 50s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 36m 49s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 43m 44s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 34m 05s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 34m 27s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 33m 24s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 41m 06s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 27s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 33m 51s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 32m 55s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 40m 15s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 31m 23s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 10m 30s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/42a72e2058f94a638059694845145fe8

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 42s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 02s :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 30m 20s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 59s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 37m 03s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 14s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 36m 38s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 34m 48s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 42m 26s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 53s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 35m 47s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 34m 56s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 41m 34s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 58s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 34m 54s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 27s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 41m 18s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 32m 24s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 17m 58s

[KB-perByte]

Hey @wormley as you correctly pointed out "This proposed change may cause some issue for anyone using purely numeric vrf names as "9" will now sort after "10" and the section will be re-ordered."

I would recommend if we can have a fresh implementation of a sorting algorithm that can handle both the pattern of vrf names and place it in a generic place like netcommon, it would have been the right approach to this issue.

Let us know if you need any information on this. Regards.

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/fb6482b838df4ef59ef39ff13b94b678

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 44s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 11s :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 26s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 48s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 38m 56s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 08s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 35m 55s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 33m 45s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 40m 43s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 08s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 35m 01s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 34m 02s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 RETRY_LIMIT in 9m 41s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 31m 54s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 34m 38s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 59s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 41m 08s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 31m 16s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 50s