ansible-collections / cisco.nxos

Ansible Network Collection for Cisco NXOS
GNU General Public License v3.0
115 stars 110 forks source link

Fix commands for community group and host VRF #795

Open TheRealBecks opened 8 months ago

TheRealBecks commented 8 months ago

draft

SUMMARY

Fixes #794

ISSUE TYPE
COMPONENT NAME

nxos_snmp_server

ADDITIONAL INFORMATION

I changed the community command logic to the user command logic, so I had to split it from community to community.groups and community.use_acls. Therefore also the data structure has to be changed what makes this PR incompatible with older versions: https://github.com/ansible-collections/cisco.nxos/pull/795/files#diff-94d7a7b6fd06a67cd2fa5a720e80962f8b320dfe00016a8e3dc58bd4f8163abaR43-R66

I will also provide the changes needed for the host VRF.

:question: Do these changes match your expectations?

If yes then the following changes need to be made:

github-actions[bot] commented 8 months ago

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

softwarefactory-project-zuul[bot] commented 8 months ago

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

softwarefactory-project-zuul[bot] commented 8 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/d8c7393c026e4344bc6c1cf7835921c3

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 42s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 59s :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 32m 13s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario02 FAILURE in 28m 28s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 26s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 58s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 FAILURE in 34m 30s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 FAILURE in 33m 25s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 FAILURE in 40m 24s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 31m 47s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 36m 03s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 FAILURE in 32m 32s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 FAILURE in 40m 08s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 31m 51s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 26s

softwarefactory-project-zuul[bot] commented 8 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/ae0621baac584bb0b3519cb283d1eaf2

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 45s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 47s :x: ansible-test-network-integration-nxos-cli-python39-scenario01 RETRY_LIMIT in 9m 18s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario02 FAILURE in 26m 48s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 21s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 50s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 36m 08s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 FAILURE in 32m 17s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 FAILURE in 39m 38s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 41s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 36m 41s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 FAILURE in 32m 49s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 FAILURE in 42m 16s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 30m 56s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 11m 34s

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/4eb1ec2adb404cfc971d0caeca940d1e

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 45s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 17s :x: ansible-test-network-integration-nxos-cli-python39-scenario01 FAILURE in 29m 52s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario02 FAILURE in 27m 26s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 50s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 23s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 35m 19s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 FAILURE in 35m 15s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 44m 56s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 35m 06s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 FAILURE in 36m 29s (non-voting) :x: ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 FAILURE in 33m 38s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 42m 10s (non-voting) :heavy_check_mark: ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 34m 19s (non-voting) :heavy_check_mark: ansible-tox-linters SUCCESS in 12m 53s