Change order of deletion for speed and duplex issue #868

ansible-collections / cisco.nxos

Ansible Network Collection for Cisco NXOS

GNU General Public License v3.0

115 stars 109 forks source link

Change order of deletion for speed and duplex issue #868 #869

Open bl1nkbl1nk opened 3 months ago

bl1nkbl1nk commented 3 months ago

SUMMARY

This is to fix https://github.com/ansible-collections/cisco.nxos/issues/868

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

nxos interfaces

ADDITIONAL INFORMATION

This just changes the order of operation for the speed and duplex when deleting them. Doing it that way doesn't cause the error that was described in bug 868

KB-perByte commented 3 months ago

@bl1nkbl1nk Can you please add unit tests and a changelog that justifies your change Regards

bl1nkbl1nk commented 3 months ago

@bl1nkbl1nk Can you please add unit tests and a changelog that justifies your change Regards

Under which release should I put the change log notes. Also can you provide some information on how to do the unit test? Is my first time to actually do a PR for this.

KB-perByte commented 3 months ago

@bl1nkbl1nk To add a changelog you can just add a new file in changelogs/fragments and add the changelog under the correct attribute. ref - PR And, this is where the interface unit tests are added, you may enhance a state-specific test or add a new function testing your scenario. Thank you for your contribution. Regards