ansible-collections / cloud.common

Common files for the Cloud collections
GNU General Public License v3.0
16 stars 24 forks source link

[PR #143/86b1ee44 backport][stable-3] Move turbo server import statements into try/except block #147

Closed patchback[bot] closed 5 months ago

patchback[bot] commented 5 months ago

This is a backport of PR #143 as merged into main (86b1ee44aed2b9fd45fae287e275ec978cdd132a).

SUMMARY

Fixes a bug where one import statement was outside the try/except block in the turbo server run_as_lookup_plugin() function. Because this is run in an async loop inside a subprocess, unhandled exceptions can cause strange behavior so it's better to have all the import statements in a try/except block that returns error messages to the user.

ISSUE TYPE
COMPONENT NAME

module_utils.turbo.server

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/246c15e3f5be4ed1876c5493e960e911

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 33s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 13s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/3bd8106750a244fa98d5f80de1e7b06c

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 43s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 33s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/4937f8b62d7e41b99471865ad29a2a53

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 41s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 53s