ansible-collections / cloud.terraform

The collection automates the management and provisioning of infrastructure as code (IaC) using the Terraform CLI tool within Ansible playbooks and Execution Environment runtimes.
GNU General Public License v3.0
100 stars 36 forks source link

Fix integration test target awscc #118

Closed abikouo closed 9 months ago

abikouo commented 9 months ago
SUMMARY

The test target awscc is failing inconsistently on the idempotency validation. Terraform reports changed because it is trying to destroy and recreate the vpc resource. The fix consists in creating a VPC subnet resource.

ISSUE TYPE
COMPONENT NAME

integration test awscc

ADDITIONAL INFORMATION
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.10%. Comparing base (8c52bf2) to head (6c562df). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== + Coverage 73.00% 74.10% +1.09% ========================================== Files 16 17 +1 Lines 1015 1058 +43 Branches 182 186 +4 ========================================== + Hits 741 784 +43 Misses 243 243 Partials 31 31 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/cloud.terraform/pull/118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Ξ” | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/cloud.terraform/pull/118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `?` | | | [units](https://app.codecov.io/gh/ansible-collections/cloud.terraform/pull/118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `74.10% <ΓΈ> (+1.49%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

softwarefactory-project-zuul[bot] commented 9 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/3fba5e8090f94783b55c4ae9845eeae5

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 08s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 13s

softwarefactory-project-zuul[bot] commented 9 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/7f2a56a091234eb98d9ea8d4010c8ae6

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 27s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 49s

softwarefactory-project-zuul[bot] commented 9 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/f73d2483440a49bebc1cbea0b8fce1a5

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 55s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 54s

patchback[bot] commented 6 months ago

Backport to stable-2: πŸ’š backport PR created

βœ… Backport PR branch: patchback/backports/stable-2/5bcd9e8941ec040337b61094693feeb496ba5640/pr-118

Backported as https://github.com/ansible-collections/cloud.terraform/pull/126

πŸ€– @patchback I'm built with octomachinery and my source is open β€” https://github.com/sanitizers/patchback-github-app.