ansible-collections / community.cassandra

Cassandra Ansible Collection
http://galaxy.ansible.com/community/cassandra
GNU General Public License v3.0
26 stars 19 forks source link

Tests for Cassandra 4.0 #150

Closed rhysmeister closed 2 years ago

rhysmeister commented 3 years ago
SUMMARY

Integration tests are running for Cassandra 4.0 although a number had to be skipped, or modified in perhaps not the best way, to get them to run successfully. There are a number of issues to sort out regrading this.

The role setup_cassandra_cluster_manager contains the following task

- meta: end_play
  when: cassandra_version.startswith('4')

So no tests using this role will run for 4.0. This should be resolved so the above task can be removed. There seems to be an issue with ccm meaning the version 4.0-rc1 cannot be downloaded by the tool. Issue opened here...

https://github.com/riptano/ccm/issues/732 (The ant built in this role might never have worked... check this also)

Identify files with...

grep -r -l "startswith('4')" *

The main issue is with cassandra_keyspace- In 4.0 you cannot specify a DC until a node, in that DC, has been added to the cluster. This means we either need to remove the DC component of these tests or additional nodes to the cluster. Might be ok to do if we stick to one instance per DC (mongodb int tests run a number of instances in one VM ok).

ISSUE TYPE
COMPONENT NAME

Integration tests

rhysmeister commented 2 years ago

Part done in https://github.com/ansible-collections/community.cassandra/pull/177

Still need to...

rhysmeister commented 2 years ago

Further work done in https://github.com/ansible-collections/community.cassandra/pull/178.

Some remaining issues in the following files...

roles/cassandra_install/tasks/main.yml
tests/integration/targets/cassandra_role/tasks/main.yml
tests/integration/targets/cassandra_keyspace/tasks/main.yml
tests/integration/targets/setup_cassandra/tasks/cassandra_auth.yml
tests/integration/targets/setup_cassandra/tasks/main.yml
tests/integration/targets/cassandra_table/tasks/main.yml
tests/integration/targets/cassandra_cqlsh/tasks/main.yml
rhysmeister commented 2 years ago

cassandra_cqlsh tests for 4.0 - https://github.com/ansible-collections/community.cassandra/pull/179

rhysmeister commented 2 years ago

cassandra_role tests for 4.0 - https://github.com/ansible-collections/community.cassandra/pull/180

rhysmeister commented 2 years ago

All done.