ansible-collections / community.cassandra

Cassandra Ansible Collection
http://galaxy.ansible.com/community/cassandra
GNU General Public License v3.0
25 stars 19 forks source link

Typo in argument name #273

Closed pflorczyk closed 6 months ago

pflorczyk commented 7 months ago
SUMMARY

There is small typo in argument name in 2 modules. data_centres should be renamed to data_centers.

ISSUE TYPE
COMPONENT NAME

cassandra_keyspace cassandra_role

rhysmeister commented 7 months ago

Hi @pflorczyk,

There's no typo. The correct British Spelling is "centre". "Center" is an American English spelling. I'm from near London so old habits die hard!

https://www.grammarly.com/blog/center-centre/

You can add an alias if it bothers you.

Cheers,

Rhys

pflorczyk commented 7 months ago

I didn't know that. Thank you for explanation :) It doesn't bother me but it's inconsistent with other modules (cassandra_role, cassandra_status)/code from this repo and cassandra itself.

rhysmeister commented 6 months ago

cassandra_role actually already has the alias but cassandra_keyspace did not. I've added this and made them a bit more consistent in https://github.com/ansible-collections/community.cassandra/pull/274

Cheers,

Rhys