get_certificate: add get_certificate_chain option

ansible-collections / community.crypto

The community.crypto collection for Ansible.

https://galaxy.ansible.com/ui/repo/published/community/crypto/

Other

97 stars 88 forks source link

get_certificate: add get_certificate_chain option #784

Closed felixfontein closed 2 months ago

felixfontein commented 2 months ago

SUMMARY

Fixes #568.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

get_certificate

github-actions[bot] commented 2 months ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://ansible-collections.github.io/community.crypto/branch/main

felixfontein commented 2 months ago

It looks like the Python 3.13 API is somewhat broken, which makes the tests fail: https://github.com/python/cpython/issues/118658

There is a fix for it already: https://github.com/python/cpython/pull/118669

felixfontein commented 2 months ago

It might be worth to include a similar hack as in https://github.com/pypa/pip/pull/12707/files#diff-5c235fa5de9ea9d116494690fc0e484c45501486f276649200c7e612c2477f88R285 to fix the Python 3.13 issues.

felixfontein commented 2 months ago

ede3e54ba13cbf0d7f7e09dc388971c5b70775c5 makes tests pass with the current Python 3.13 pre-releases. It should also work fine once the bug has been fixed.

felixfontein commented 2 months ago

@markuman thanks for reviewing this!