search

ansible-collections / community.crypto

The community.crypto collection for Ansible.
https://galaxy.ansible.com/ui/repo/published/community/crypto/
Other
97 stars 88 forks source link

Disable unit tests that fail with cryptography 43.0.0 #786

Closed felixfontein closed 2 months ago

felixfontein commented 2 months ago
SUMMARY

https://cryptography.io/en/latest/changelog/#v43-0-0 - name attribute strings cannot be empty anymore.

ISSUE TYPE
COMPONENT NAME

unit tests

patchback[bot] commented 2 months ago

Backport to stable-1: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d509af540d080c01128404b315dfdf785f1c9737 on top of patchback/backports/stable-1/d509af540d080c01128404b315dfdf785f1c9737/pr-786

Backporting merged PR #786 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/community.crypto.git
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-1/d509af540d080c01128404b315dfdf785f1c9737/pr-786 upstream/stable-1
  4. Now, cherry-pick PR #786 contents into that branch: 
    $ git cherry-pick -x d509af540d080c01128404b315dfdf785f1c9737

    If it'll yell at you with something like fatal: Commit d509af540d080c01128404b315dfdf785f1c9737 is a merge but no -m option was given., add -m 1 as follows instead:

    $ git cherry-pick -m1 -x d509af540d080c01128404b315dfdf785f1c9737
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #786 as close to the original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-1/d509af540d080c01128404b315dfdf785f1c9737/pr-786
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.