digital_ocean_domain: Fails if you have more than 20 domains

[elcfd]

SUMMARY

The digital_ocean_domain module fails if you have more than 20 domains in your project. This is because the Digitial Ocean domains api list endpoint is paginated with a default value of 20 (docs: https://docs.digitalocean.com/reference/api/api-reference/#operation/domains_list)

ISSUE TYPE

• Bug Report

COMPONENT NAME

• digital_ocean_domain module

ANSIBLE VERSION

ansible [core 2.14.5]
  config file = None
  configured module search path = ['/home/tank/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/tank/.local/lib/python3.10/site-packages/ansible
  ansible collection location = /home/tank/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/tank/.local/bin/ansible
  python version = 3.10.10 (main, Mar  5 2023, 22:26:53) [GCC 12.2.1 20230201] (/usr/bin/python)
  jinja version = 3.1.2
  libyaml = True

COLLECTION VERSION

# /home/tank/.local/lib/python3.10/site-packages/ansible_collections
Collection             Version
---------------------- -------
community.digitalocean 1.23.0 

CONFIGURATION

CONFIG_FILE() = None

OS / ENVIRONMENT

• MacBook Pro Apple M1 Ventura 13.3.1
• Python 3.10

STEPS TO REPRODUCE

• Have more than 20 domains in your Digital Ocean account/project
• Run the playbook below with a domain that is greater than 20 on your list of domains and already exists

• hosts: localhost tasks:
  • name: Create a domain community.digitalocean.digital_ocean_domain: state: present name: my.digitalocean.domain

EXPECTED RESULTS

• The module should cope with the fact that the domain already exists and report no changes necessary

ACTUAL RESULTS

• Due to the pagination issue the domain is not found by the digital_ocean_domain module and the module tries to create the already existing domain
• The Digital Ocean api errors (because the domain already exists) causing the playbook to fail

Data domain 'my.digitalodean.domain': name already exists