ansible-collections / community.digitalocean

This Ansible collection contains modules for assisting in the automation of the DigitalOcean cloud.
https://galaxy.ansible.com/community/digitalocean/
GNU General Public License v3.0
140 stars 57 forks source link

add CNAME example to domain_record module #314

Closed port19x closed 1 year ago

port19x commented 1 year ago
SUMMARY

Here I added an example for the CNAME type of the domain_record module. I believe subdomains to be a particularly common usage of this record type. I added the subdomains I use.

ISSUE TYPE
COMPONENT NAME

digital_ocean_domain_record.py

ADDITIONAL INFORMATION

When setting up my cname records it wasn't apparent what to put into the data, domain, or name fields, leading to a cryptic error on CNAMEs not being allowed to refer to themselves.

codecov[bot] commented 1 year ago

Codecov Report

Merging #314 (c793e65) into main (090b5d8) will decrease coverage by 33.12%. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #314       +/-   ##
===========================================
- Coverage   64.20%   31.08%   -33.12%     
===========================================
  Files          45       45               
  Lines        3587     3587               
  Branches      732      732               
===========================================
- Hits         2303     1115     -1188     
- Misses        984     2452     +1468     
+ Partials      300       20      -280     
Flag Coverage Δ
integration ?
sanity 26.40% <ø> (ø)
units 64.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/modules/digital_ocean_domain_record.py 16.77% <ø> (-30.21%) :arrow_down:

... and 37 files with indirect coverage changes