ansible-collections / community.digitalocean

This Ansible collection contains modules for assisting in the automation of the DigitalOcean cloud.
https://galaxy.ansible.com/community/digitalocean/
GNU General Public License v3.0
140 stars 57 forks source link

Add project_name parameter to the kubernetes module #333

Closed raman-babich closed 10 months ago

raman-babich commented 11 months ago
SUMMARY

Fixes #264

ISSUE TYPE
COMPONENT NAME

digital_ocean_kubernetes

ADDITIONAL INFORMATION
codecov[bot] commented 11 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (23f775f) 62.52% compared to head (91b350e) 62.81%.

Files Patch % Lines
plugins/modules/digital_ocean_kubernetes.py 58.82% 5 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #333 +/- ## ========================================== + Coverage 62.52% 62.81% +0.29% ========================================== Files 46 46 Lines 3602 3617 +15 Branches 738 743 +5 ========================================== + Hits 2252 2272 +20 + Misses 1059 1050 -9 - Partials 291 295 +4 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.digitalocean/pull/333/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.digitalocean/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `65.41% <35.29%> (+0.02%)` | :arrow_up: | | [sanity](https://app.codecov.io/gh/ansible-collections/community.digitalocean/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `26.01% <0.00%> (-0.11%)` | :arrow_down: | | [units](https://app.codecov.io/gh/ansible-collections/community.digitalocean/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `60.64% <23.52%> (-1.71%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mamercad commented 11 months ago

Try rebasing because of #335 please.

mamercad commented 10 months ago

@raman-babich apologies for pushing to your branch; I'm in the process of refactoring the integration testing workflows (and having this PR open is helping me). I've reworked the integration testing workflows to matrix over the various modules (versus having all of their outputs in a single pass). There are quite a few modules in this collection at this point, and although the output in the PR becomes very noisy, it's helpful to be able to quickly figure out which module(s) are failing.