ansible-collections / community.digitalocean

This Ansible collection contains modules for assisting in the automation of the DigitalOcean cloud.
https://galaxy.ansible.com/community/digitalocean/
GNU General Public License v3.0
140 stars 57 forks source link

Moved http status check up to catch more cases #362

Closed jdrowell closed 6 months ago

jdrowell commented 7 months ago
SUMMARY

When using reduced Scopes, some API calls may fail with a 403 if you didn't provide enough scopes for all of the actions being performed. This caused a crash due to some fields not existing in the response, and them being referenced before the check for the http code. I just moved the check a little bit up in the code.

ISSUE TYPE
COMPONENT NAME

digital_ocean_droplet

ADDITIONAL INFORMATION

To reproduce the error, just create a new API Key without any droplet Scopes and try to create a new droplet. Other cases relate to specific options used in the create and the scopes that the key has.