ansible-collections / community.docker

Community Docker Collection for Ansible: modules and plugins for working with Docker
https://galaxy.ansible.com/ui/repo/published/community/docker/
GNU General Public License v3.0
203 stars 121 forks source link

Differences between vendored Docker SDK for Python code and Docker SDK for Python #435

Open felixfontein opened 2 years ago

felixfontein commented 2 years ago
SUMMARY

This issue is for tracking differences that need to be checked (whether our vendored code needs to be updated accordingly) that appear in the Docker SDK for Python in https://github.com/docker/docker-py/commits/main

ISSUE TYPE
COMPONENT NAME

plugins/module_utils/_api/

felixfontein commented 2 years ago

434 updates to up to https://github.com/docker/docker-py/commit/3f0095a7c1966c521652314e524ff362c24ff58c. Not yet there: https://github.com/docker/docker-py/compare/3f0095a7c1966c521652314e524ff362c24ff58c..main

felixfontein commented 2 years ago

438 updates to up to https://github.com/docker/docker-py/commit/42789818bed5d86b487a030e2e60b02bf0cfa284. Not yet there: https://github.com/docker/docker-py/compare/42789818bed5d86b487a030e2e60b02bf0cfa284..main

felixfontein commented 2 years ago

No update required for current state https://github.com/docker/docker-py/commit/e901eac7a8c5f29c7720eafb9f58c8356cca2324. Not yet there: https://github.com/docker/docker-py/compare/e901eac7a8c5f29c7720eafb9f58c8356cca2324..main

felixfontein commented 2 years ago

Docker SDK for Python 6.0.0 has been released. All changes in it have been incorporated (i.e. in the last 10 days there have been no new commits which affect code that's vendored here).

felixfontein commented 2 years ago

No update required for current state https://github.com/docker/docker-py/commit/923e067dddc3d4b86e4e620a99fcdcdafbd17a98. Not yet there: https://github.com/docker/docker-py/compare/923e067dddc3d4b86e4e620a99fcdcdafbd17a98..main

felixfontein commented 1 year ago

Not yet there: https://github.com/docker/docker-py/compare/82cf559b5a641f53e9035b44b91f829f3b4cca80...main

felixfontein commented 1 year ago

581 and #582 update this to https://github.com/docker/docker-py/compare/aca129dd69fa068da247d37266110c3a9889a780...main

felixfontein commented 1 year ago

619 updates this to https://github.com/docker/docker-py/compare/bc4c0d7cf4f6f794f9e92d93ddec02626eda739c...main.

felixfontein commented 1 year ago

694 updates this to https://github.com/docker/docker-py/compare/c38656dc7894363f32317affecc3e4279e1163f8...main.

felixfontein commented 6 months ago

There currently isn't really something to update. The only potentially interesting change is https://github.com/docker/docker-py/pull/3185, but the only relevant part is that it removes features that we still need (ssl_version and tls_hostname). I don't see why tls_hostname is removed, since the only part of it that needs something removed from Python 3.12 is the tests, but not the feature itself. Deprecating ssl_version is fine though.

So the next changes to look for are at https://github.com/docker/docker-py/compare/b6464dbed92b14b2c61d5ee49805fce041a3e083...main.

felixfontein commented 4 months ago

There currently isn't really something to update, since the only real change was already integrated in this collection before it got merged to Docker SDK for Python (the requests fix). The next changes to look for are at https://github.com/docker/docker-py/compare/a3652028b1ead708bd9191efb286f909ba6c2a49...main.

felixfontein commented 1 month ago

There are currently only docs and tests changes. The next changes to look for are at https://github.com/docker/docker-py/compare/a8bac8822127a8f446893a4e7e60d4b5149333bf...main.