search

ansible-collections / community.fortios

http://galaxy.ansible.com/community/fortios
GNU General Public License v3.0
0 stars 2 forks source link

missing fixtures #4

Closed dericcrago closed 3 years ago

dericcrago commented 3 years ago
SUMMARY

while reviewing the removal from community.network PR I realized that several fixtures were missing. The tests were "passing", because the missing fixtures marked the tests as "skipped", as seen here. This PR restores the fixtures and thus runs all tests, as seen here.

COMPONENT NAME

test fixtures

codecov[bot] commented 3 years ago

Codecov Report

Merging #4 (3ba1e9b) into main (28c2e0c) will increase coverage by 22.33%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
+ Coverage   42.35%   64.69%   +22.33%     
===========================================
  Files          56       56               
  Lines        3501     3501               
  Branches      300      300               
===========================================
+ Hits         1483     2265      +782     
+ Misses       1961     1146      -815     
- Partials       57       90       +33
Impacted Files Coverage Δ
...ns/community/fortios/plugins/modules/fmgr_query.py 17.80% <0.00%> (+5.47%) :arrow_up:
...munity/fortios/plugins/modules/fmgr_secprof_web.py 50.98% <0.00%> (+17.64%) :arrow_up:
...munity/fortios/plugins/modules/fmgr_secprof_ips.py 50.00% <0.00%> (+18.00%) :arrow_up:
...munity/fortios/plugins/modules/fmgr_secprof_dns.py 53.06% <0.00%> (+18.36%) :arrow_up:
...mmunity/fortios/plugins/modules/fmgr_fwpol_ipv4.py 44.92% <0.00%> (+20.28%) :arrow_up:
...mmunity/fortios/plugins/modules/fmgr_secprof_av.py 54.16% <0.00%> (+20.83%) :arrow_up:
...ty/fortios/plugins/modules/fmgr_secprof_appctrl.py 54.16% <0.00%> (+20.83%) :arrow_up:
...unity/fortios/plugins/modules/fmgr_fwobj_ippool.py 54.90% <0.00%> (+23.52%) :arrow_up:
...unity/fortios/plugins/modules/fmgr_secprof_voip.py 54.90% <0.00%> (+23.52%) :arrow_up:
...nity/fortios/plugins/modules/fmgr_secprof_proxy.py 54.90% <0.00%> (+23.52%) :arrow_up:
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28c2e0c...3ba1e9b. Read the comment docs.